Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session span start time per new clock #48

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Nov 6, 2023

Goal

This services uses an OpenTelemetry-compatible clock now, so now() returns in nano seconds. Make sure interpret it as such.

Testing

Existing tests pass

Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@bidetofevil bidetofevil marked this pull request as ready for review November 6, 2023 17:27
@bidetofevil bidetofevil requested a review from a team as a code owner November 6, 2023 17:27
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #48 (912279b) into master (143544f) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files         305      305           
  Lines       10053    10053           
  Branches     1447     1447           
=======================================
  Hits         7416     7416           
  Misses       2067     2067           
  Partials      570      570           
Files Coverage Δ
...roid/embracesdk/internal/spans/SpansServiceImpl.kt 86.15% <100.00%> (ø)

@bidetofevil bidetofevil merged commit 978a47a into master Nov 7, 2023
4 checks passed
@bidetofevil bidetofevil deleted the hho/fix-session-span branch November 7, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants